From 32111251f87d1f101dd8e90a5d1d6684f20012a5 Mon Sep 17 00:00:00 2001
From: Rob Riggs <rob@pangalactic.org>
Date: Sun, 23 Feb 2020 15:57:04 -0600
Subject: [PATCH] Fix SET_PASSALL handling.

---
 TNC/KissHardware.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/TNC/KissHardware.cpp b/TNC/KissHardware.cpp
index 445fb1a..573551e 100644
--- a/TNC/KissHardware.cpp
+++ b/TNC/KissHardware.cpp
@@ -430,13 +430,13 @@ void Hardware::handle_request(hdlc::IoFrame* frame) {
 
     case hardware::SET_PASSALL:
         DEBUG("SET_PASSALL");
-        if (!*it) {
-          options &= ~KISS_OPTION_PASSALL;
-        } else {
+        if (*it) {
           options |= KISS_OPTION_PASSALL;
+        } else {
+          options &= ~KISS_OPTION_PASSALL;
         }
         update_crc();
-        break;
+        [[fallthrough]];
     case hardware::GET_PASSALL:
         DEBUG("GET_PASSALL");
         reply8(hardware::GET_PASSALL, options & KISS_OPTION_PASSALL ? 1 : 0);
@@ -568,7 +568,6 @@ void Hardware::handle_ext_request(hdlc::IoFrame* frame) {
         }
         osMessagePut(audioInputQueueHandle, audio::UPDATE_SETTINGS,
             osWaitForever);
-        updateModulator();
         [[fallthrough]];
     case hardware::EXT_GET_MODEM_TYPE[1]:
         DEBUG("EXT_GET_MODEM_TYPE");