All plugins: removed apply settings in constructors as it causes segfaults

plugins/samplesink/bladerfoutput/bladerfoutput.cpp

@@ -47,8 +47,6 @@ BladerfOutput::BladerfOutput(DeviceSinkAPI *deviceAPI) :
     m_sampleSourceFifo.resize(16*BLADERFOUTPUT_BLOCKSIZE);
     openDevice();
     m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
-
-    applySettings(m_settings, true);
 }
 
 BladerfOutput::~BladerfOutput()

plugins/samplesink/filesink/filesinkoutput.cpp

@@ -49,7 +49,6 @@ FileSinkOutput::FileSinkOutput(DeviceSinkAPI *deviceAPI) :
 	m_startingTimeStamp(0),
 	m_masterTimer(deviceAPI->getMasterTimer())
 {
-    applySettings(m_settings, true);
 }
 
 FileSinkOutput::~FileSinkOutput()

plugins/samplesink/hackrfoutput/hackrfoutput.cpp

@@ -47,8 +47,6 @@ HackRFOutput::HackRFOutput(DeviceSinkAPI *deviceAPI) :
 {
     openDevice();
     m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
-
-    applySettings(m_settings, true);
 }
 
 HackRFOutput::~HackRFOutput()

plugins/samplesink/limesdroutput/limesdroutput.cpp

@@ -55,8 +55,6 @@ LimeSDROutput::LimeSDROutput(DeviceSinkAPI *deviceAPI) :
     openDevice();
     resumeTxBuddies();
     resumeRxBuddies();
-
-    applySettings(m_settings, true, false);
 }
 
 LimeSDROutput::~LimeSDROutput()

plugins/samplesink/plutosdroutput/plutosdroutput.cpp

@@ -45,8 +45,6 @@ PlutoSDROutput::PlutoSDROutput(DeviceSinkAPI *deviceAPI) :
     suspendBuddies();
     openDevice();
     resumeBuddies();
-
-    applySettings(m_settings, true);
 }
 
 PlutoSDROutput::~PlutoSDROutput()

plugins/samplesink/sdrdaemonsink/sdrdaemonsinkoutput.cpp

@@ -47,7 +47,6 @@ SDRdaemonSinkOutput::SDRdaemonSinkOutput(DeviceSinkAPI *deviceAPI) :
     m_startingTimeStamp(0),
 	m_masterTimer(deviceAPI->getMasterTimer())
 {
-    applySettings(m_settings, true);
 }
 
 SDRdaemonSinkOutput::~SDRdaemonSinkOutput()

plugins/samplesource/airspy/airspyinput.cpp

@@ -52,8 +52,6 @@ AirspyInput::AirspyInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true);
 }
 
 AirspyInput::~AirspyInput()

plugins/samplesource/bladerfinput/bladerfinput.cpp

@@ -53,8 +53,6 @@ BladerfInput::BladerfInput(DeviceSourceAPI *deviceAPI) :
     m_deviceAPI->addSink(m_fileSink);
 
     m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
-
-    applySettings(m_settings, false);
 }
 
 BladerfInput::~BladerfInput()

plugins/samplesource/fcdpro/fcdproinput.cpp

@@ -54,8 +54,6 @@ FCDProInput::FCDProInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true);
 }
 
 FCDProInput::~FCDProInput()

plugins/samplesource/fcdproplus/fcdproplusinput.cpp

@@ -53,8 +53,6 @@ FCDProPlusInput::FCDProPlusInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true);
 }
 
 FCDProPlusInput::~FCDProPlusInput()

plugins/samplesource/filesource/filesourceinput.cpp

@@ -54,6 +54,9 @@ FileSourceInput::FileSourceInput(DeviceSourceAPI *deviceAPI) :
     m_startingTimeStamp(0),
     m_masterTimer(deviceAPI->getMasterTimer())
 {
+    qDebug("FileSourceInput::FileSourceInput: device source engine: %p", m_deviceAPI->getDeviceSourceEngine());
+    qDebug("FileSourceInput::FileSourceInput: device source engine message queue: %p", m_deviceAPI->getDeviceEngineInputMessageQueue());
+    qDebug("FileSourceInput::FileSourceInput: device source: %p", m_deviceAPI->getDeviceSourceEngine()->getSource());
 }
 
 FileSourceInput::~FileSourceInput()

plugins/samplesource/hackrfinput/hackrfinput.cpp

@@ -56,8 +56,6 @@ HackRFInput::HackRFInput(DeviceSourceAPI *deviceAPI) :
     m_deviceAPI->addSink(m_fileSink);
 
     m_deviceAPI->setBuddySharedPtr(&m_sharedParams);
-
-    applySettings(m_settings, true);
 }
 
 HackRFInput::~HackRFInput()

plugins/samplesource/limesdrinput/limesdrinput.cpp

@@ -61,8 +61,6 @@ LimeSDRInput::LimeSDRInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true, false);
 }
 
 LimeSDRInput::~LimeSDRInput()

plugins/samplesource/plutosdrinput/plutosdrinput.cpp

@@ -52,8 +52,6 @@ PlutoSDRInput::PlutoSDRInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true);
 }
 
 PlutoSDRInput::~PlutoSDRInput()

plugins/samplesource/rtlsdr/rtlsdrinput.cpp

@@ -59,8 +59,6 @@ RTLSDRInput::RTLSDRInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true);
 }
 
 RTLSDRInput::~RTLSDRInput()

plugins/samplesource/sdrplay/sdrplayinput.cpp

@@ -53,8 +53,6 @@ SDRPlayInput::SDRPlayInput(DeviceSourceAPI *deviceAPI) :
     sprintf(recFileNameCStr, "test_%d.sdriq", m_deviceAPI->getDeviceUID());
     m_fileSink = new FileRecord(std::string(recFileNameCStr));
     m_deviceAPI->addSink(m_fileSink);
-
-    applySettings(m_settings, true, true);
 }
 
 SDRPlayInput::~SDRPlayInput()

pluginssrv/samplesource/filesource/CMakeLists.txt

@@ -7,12 +7,14 @@ set(filesource_SOURCES
 	${PLUGIN_PREFIX}/filesourceinput.cpp
 	${PLUGIN_PREFIX}/filesourceplugin.cpp
 	${PLUGIN_PREFIX}/filesourcethread.cpp
+	${PLUGIN_PREFIX}/filesourcesettings.cpp
 )
 
 set(filesource_HEADERS
 	${PLUGIN_PREFIX}/filesourceinput.h
 	${PLUGIN_PREFIX}/filesourceplugin.h
 	${PLUGIN_PREFIX}/filesourcethread.h
+    ${PLUGIN_PREFIX}/filesourcesettings.h
 )
 
 include_directories(

sdrbase/dsp/filerecord.cpp

@@ -95,8 +95,6 @@ void FileRecord::stopRecording()
 
 bool FileRecord::handleMessage(const Message& message)
 {
-	qDebug() << "FileRecord::handleMessage";
-
 	if (DSPSignalNotification::match(message))
 	{
 		DSPSignalNotification& notif = (DSPSignalNotification&) message;