sane-project-website/old-archive/1999-06/0154.html

86 wiersze
4.3 KiB
HTML

This file contains invisible Unicode characters!

This file contains invisible Unicode characters that may be processed differently from what appears below. If your use case is intentional and legitimate, you can safely ignore this warning. Use the Escape button to reveal hidden characters.

<!-- received="Wed Jun 23 10:06:28 1999 PDT" -->
<!-- sent="23 Jun 1999 10:07:14 -0700" -->
<!-- name="David Fox" -->
<!-- email="dsfox@cogsci.ucsd.edu" -->
<!-- subject="Fix for grayscale scans with gamma &lt; 1.0" -->
<!-- id="" -->
<!-- inreplyto="Sat, 22 May 1999 16:52:34 +0200"" -->
<title>sane-devel: Fix for grayscale scans with gamma &lt; 1.0</title>
<h1>Fix for grayscale scans with gamma &lt; 1.0</h1>
<b>David Fox</b> (<a href="mailto:dsfox@cogsci.ucsd.edu"><i>dsfox@cogsci.ucsd.edu</i></a>)<br>
<i>23 Jun 1999 10:07:14 -0700</i>
<p>
<ul>
<li> <b>Messages sorted by:</b> <a href="date.html#154">[ date ]</a><a href="index.html#154">[ thread ]</a><a href="subject.html#154">[ subject ]</a><a href="author.html#154">[ author ]</a>
<!-- next="start" -->
<li> <b>Next message:</b> <a href="0155.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Previous message:</b> <a href="0153.html">Simon Piette: "Re: Umax 1200S on LinuxPPC R5"</a>
<!-- nextthread="start" -->
<li> <b>Next in thread:</b> <a href="0155.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0155.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0163.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0168.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0169.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<!-- reply="end" -->
</ul>
<!-- body="start" -->
Oliver Rauch &lt;<a href="mailto:oliver.rauch@Wolfsburg.DE">oliver.rauch@Wolfsburg.DE</a>&gt; writes:<br>
<p>
<i>&gt; I uploaded xsane-0.26 to my homepage:</i><br>
<i>&gt; <a href="http://www.wolfsburg.de/~rauch/sane/sane-xsane.html">http://www.wolfsburg.de/~rauch/sane/sane-xsane.html</a></i><br>
<p>
Oliver,<br>
<p>
I've found a bug whose most obvious symptom is that grayscale scans<br>
with a gamma &lt; 1.0 come out pure black. There are a couple of places<br>
where gamma is declared as an int rather than a double (see below.)<br>
These int declarations look odd, like they are a temporary solution to<br>
some other problem. I haven't tested the resulting code extensively,<br>
but grayscale with gamma &lt; 1.0 does now work.<br>
<pre>
--
David Fox <a href="http://hci.ucsd.edu/dsf">http://hci.ucsd.edu/dsf</a> xoF divaD
UCSD HCI Lab baL ICH DSCU
<p>
diff -ru xsane-0.26/frontend/xsane-scan.c~ xsane-0.26/frontend/xsane-scan.c
--- xsane-0.26/frontend/xsane-scan.c~ Fri May 14 12:22:25 1999
+++ xsane-0.26/frontend/xsane-scan.c Wed Jun 23 09:56:40 1999
@@ -1661,7 +1661,7 @@
}
else if (xsane.scanner_gamma_gray) /* only scanner gray gamma function available */
{
- int gamma;
+ double gamma;
/* ok, the scanner only supports gray gamma function */
/* if we are doing a grayscale scan everyting is ok, */
/* for a color scan the software has to do the gamma correction set by the component slider */
@@ -1731,7 +1731,7 @@
if (xsane.xsane_color == 0) /* no color scan */
{
- int gamma;
+ double gamma;
if (xsane.xsane_mode == XSANE_COPY)
{
<p>
<pre>
--
Source code, list archive, and docs: <a href="http://www.mostang.com/sane/">http://www.mostang.com/sane/</a>
To unsubscribe: echo unsubscribe sane-devel | mail <a href="mailto:majordomo@mostang.com">majordomo@mostang.com</a>
</pre>
<!-- body="end" -->
<p>
<ul>
<!-- next="start" -->
<li> <b>Next message:</b> <a href="0155.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Previous message:</b> <a href="0153.html">Simon Piette: "Re: Umax 1200S on LinuxPPC R5"</a>
<!-- nextthread="start" -->
<li> <b>Next in thread:</b> <a href="0155.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0155.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0163.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0168.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<li> <b>Reply:</b> <a href="0169.html">Oliver Rauch: "Re: Fix for grayscale scans with gamma &lt; 1.0"</a>
<!-- reply="end" -->
</ul>