sane-project-website/old-archive/1999-04/0221.html

<!-- received="Wed Apr 14 02:25:00 1999 PDT" -->
<!-- sent="Wed, 14 Apr 1999 11:24:25 +0200 (MET DST)" -->
<!-- name="=?ISO-8859-1?Q?Mikko_Ty=F6l=E4j=E4rvi?=" -->
<!-- email="mikko@securitydynamics.com" -->
<!-- subject="Re: new release delayed" -->
<!-- id="" -->
<!-- inreplyto="199904140428.VAA17685@panda.mostang.com" -->
<title>sane-devel: Re: new release delayed</title>
<h1>Re: new release delayed</h1>
<b>=?ISO-8859-1?Q?Mikko_Ty=F6l=E4j=E4rvi?=</b> (<a href="mailto:mikko@securitydynamics.com"><i>mikko@securitydynamics.com</i></a>)<br>
<i>Wed, 14 Apr 1999 11:24:25 +0200 (MET DST)</i>
<p>
<ul>
<li> <b>Messages sorted by:</b> <a href="date.html#221">[ date ]</a><a href="index.html#221">[ thread ]</a><a href="subject.html#221">[ subject ]</a><a href="author.html#221">[ author ]</a>
<!-- next="start" -->
<li> <b>Next message:</b> <a href="0222.html">Alexander Jerjomin: "wait for so long time"</a>
<li> <b>Previous message:</b> <a href="0220.html">David Mosberger-Tang: "new release delayed"</a>
<li> <b>In reply to:</b> <a href="0220.html">David Mosberger-Tang: "new release delayed"</a>
<!-- nextthread="start" -->
<!-- reply="end" -->
</ul>
<!-- body="start" -->
On Tue, 13 Apr 1999, David Mosberger-Tang wrote:<br>
<p>
<i>&gt; In case you're wondering what's happening with sane-1.0.1: I'm</i><br>
<i>&gt; basically ready with the (hopefully) last pre-release but I currently</i><br>
<i>&gt; am experiencing difficulties contacting the ftp server (hosted by</i><br>
<i>&gt; redhat).  As soon as that problem has been resolved, I'll update the</i><br>
<i>&gt; ftp site and send a new announcement (in the meantime, please send me</i><br>
<i>&gt; patches that solve serious bugs only).</i><br>
<p>
On April 6 I sent a patch to sane-devel, which fixed a few bugs in the<br>
SCSI support for FreeBSD.<br>
<p>
However, now it seems that in a misdirected effort to clean up my<br>
changes before generating and sending the patch I seriously botched<br>
it...<br>
<p>
Here is the faulty bit:<br>
<p>
--- sanei/sanei_scsi.c.org	Mon Apr  5 14:26:35 1999<br>
+++ sanei/sanei_scsi.c	Mon Apr  5 14:58:17 1999<br>
<p>
@@ -1689,7 +1689,7 @@<br>
    char*		data_buf;<br>
    size_t		data_len;<br>
    <br>
-   if (fd &lt; 0) {<br>
+   if (fd &lt; 0 || fd &gt; CAM_MAXDEVS || cam_devices[fd] != NULL) {<br>
       fprintf(stderr, "attempt to reference invalid unit %d\n", fd);<br>
       return SANE_STATUS_INVAL;<br>
    }<br>
<p>
A quick visual inspection of the changed line should be enough to<br>
realize that the "!= NULL" should be "== NULL". I.e. it should read:<br>
<p>
 "if the faked fd is out-of bounds or there is no such open device"<br>
<p>
That is not quite what the above evaluates to :(<br>
<p>
I sincerely apologize of being sloppy, and hope that a correction<br>
will make it in time for the release.<br>
<p>
	/Mikko<br>
<p>
P.S. I *do* consider this serious, as it completely hoses<br>
     SANE under<65>FreeBSD.<br>
<p>
<p>
 Mikko Tyo"la"ja"rvi________________________________mikko@securitydynamics.com<br>
 SecurityDynamics<br>
<p>
<p>
<p>
<pre>
--
Source code, list archive, and docs: <a href="http://www.mostang.com/sane/">http://www.mostang.com/sane/</a>
To unsubscribe: echo unsubscribe sane-devel | mail <a href="mailto:majordomo@mostang.com">majordomo@mostang.com</a>
</pre>
<!-- body="end" -->
<p>
<ul>
<!-- next="start" -->
<li> <b>Next message:</b> <a href="0222.html">Alexander Jerjomin: "wait for so long time"</a>
<li> <b>Previous message:</b> <a href="0220.html">David Mosberger-Tang: "new release delayed"</a>
<li> <b>In reply to:</b> <a href="0220.html">David Mosberger-Tang: "new release delayed"</a>
<!-- nextthread="start" -->
<!-- reply="end" -->
</ul>