refactor: Change for loop to list comprehensions

Not only more concise and shorter, it's notably faster

Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>

RNS/Utilities/rnid.py

@@ -82,7 +82,7 @@ def main():
         parser.add_argument("-w", "--write", metavar="file", action="store", default=None, help="output file path", type=str)
         parser.add_argument("-f", "--force", action="store_true", default=None, help="write output even if it overwrites existing files")
         parser.add_argument("-I", "--stdin", action="store_true", default=False, help=argparse.SUPPRESS) # "read input from STDIN instead of file"
-        parser.add_argument("-O", "--stdout", action="store_true", default=False, help=argparse.SUPPRESS) # help="write output to STDOUT instead of file", 
+        parser.add_argument("-O", "--stdout", action="store_true", default=False, help=argparse.SUPPRESS) # help="write output to STDOUT instead of file",
 
         parser.add_argument("-R", "--request", action="store_true", default=False, help="request unknown Identities from the network")
         parser.add_argument("-t", action="store", metavar="seconds", type=float, help="identity request timeout before giving up", default=RNS.Transport.PATH_REQUEST_TIMEOUT)
@@ -93,14 +93,10 @@ def main():
         parser.add_argument("-B", "--base32", action="store_true", default=False, help="Use base32-encoded input and output")
 
         parser.add_argument("--version", action="version", version="rnid {version}".format(version=__version__))
-        
+
         args = parser.parse_args()
 
-        ops = 0;
-        for t in [args.encrypt, args.decrypt, args.validate, args.sign]:
-            if t:
-                ops += 1
-        
+        ops = sum(1 for t in [args.encrypt, args.decrypt, args.validate, args.sign] if t)
         if ops > 1:
             RNS.log("This utility currently only supports one of the encrypt, decrypt, sign or verify operations per invocation", RNS.LOG_ERROR)
             exit(1)
@@ -179,7 +175,7 @@ def main():
             quietness = args.quiet
             if verbosity != 0 or quietness != 0:
                 targetloglevel = targetloglevel+verbosity-quietness
-            
+
             # Start Reticulum
             reticulum = RNS.Reticulum(configdir=args.config, loglevel=targetloglevel)
             RNS.compact_log_fmt = True
@@ -234,7 +230,7 @@ def main():
                     RNS.log("Invalid hexadecimal hash provided", RNS.LOG_ERROR)
                     exit(7)
 
-                
+
             else:
                 # Try loading Identity from file
                 if not os.path.isfile(identity_str):
@@ -391,7 +387,7 @@ def main():
                             RNS.log("Could not open output file for writing", RNS.LOG_ERROR)
                             RNS.log("The contained exception was: "+str(e), RNS.LOG_ERROR)
                             exit(15)
-                
+
                 # TODO: Actually expand this to a good solution
                 # probably need to create a wrapper that takes
                 # into account not closing stdout when done
@@ -415,12 +411,12 @@ def main():
 
                         if not args.stdout:
                             RNS.log("Signing "+str(args.read))
-                        
+
                         try:
                             data_output.write(identity.sign(data_input.read()))
                             data_output.close()
                             data_input.close()
-                            
+
                             if not args.stdout:
                                 if args.read:
                                     RNS.log("File "+str(args.read)+" signed with "+str(identity)+" to "+str(args.write))
@@ -448,7 +444,7 @@ def main():
                     else:
                         # if not args.stdout:
                         #     RNS.log("Verifying "+str(args.validate)+" for "+str(args.read))
-                        
+
                         try:
                             try:
                                 sig_input = open(args.validate, "rb")
@@ -498,7 +494,7 @@ def main():
 
                         if not args.stdout:
                             RNS.log("Encrypting "+str(args.read))
-                        
+
                         try:
                             more_data = True
                             while more_data:
@@ -545,7 +541,7 @@ def main():
 
                         if not args.stdout:
                             RNS.log("Decrypting "+str(args.read)+"...")
-                        
+
                         try:
                             more_data = True
                             while more_data:
@@ -597,4 +593,4 @@ def main():
         exit(255)
 
 if __name__ == "__main__":
-    main()
+    main()