kopia lustrzana https://github.com/micropython/micropython
bd556b6996
There were two issues with the existing code: 1. "1 << i" is computed as a 32-bit number so would overflow when executed on 64-bit machines (when mp_uint_t is 64-bit). This meant that *args beyond 32 positions would not be handled correctly. 2. star_args must fit as a positive small int so that it is encoded correctly in the emitted code. MP_SMALL_INT_BITS is too big because it overflows a small int by 1 bit. MP_SMALL_INT_BITS - 1 does not work because it produces a signed small int which is then sign extended when extracted (even by mp_obj_get_int_truncated), and this sign extension means that any position arg after *args is also treated as a star-arg. So the maximum bit position is MP_SMALL_INT_BITS - 2. This means that MP_OBJ_SMALL_INT_VALUE() can be used instead of mp_obj_get_int_truncated() to get the value of star_args. These issues are fixed by this commit, and a test added. Signed-off-by: Damien George <damien@micropython.org> |
||
|---|---|---|
| .. | ||
| basics | ||
| cmdline | ||
| cpydiff | ||
| esp32 | ||
| extmod | ||
| feature_check | ||
| float | ||
| import | ||
| inlineasm | ||
| internal_bench | ||
| io | ||
| jni | ||
| micropython | ||
| misc | ||
| multi_bluetooth | ||
| multi_net | ||
| net_hosted | ||
| net_inet | ||
| perf_bench | ||
| pyb | ||
| pybnative | ||
| qemu-arm | ||
| stress | ||
| thread | ||
| unicode | ||
| unix | ||
| wipy | ||
| README | ||
| run-internalbench.py | ||
| run-multitests.py | ||
| run-natmodtests.py | ||
| run-perfbench.py | ||
| run-tests-exp.py | ||
| run-tests-exp.sh | ||
| run-tests.py | ||
README
This directory contains tests for various functionality areas of MicroPython. To run all stable tests, run "run-tests.py" script in this directory. Tests of capabilities not supported on all platforms should be written to check for the capability being present. If it is not, the test should merely output 'SKIP' followed by the line terminator, and call sys.exit() to raise SystemExit, instead of attempting to test the missing capability. The testing framework (run-tests.py in this directory, test_main.c in qemu_arm) recognizes this as a skipped test. There are a few features for which this mechanism cannot be used to condition a test. The run-tests.py script uses small scripts in the feature_check directory to check whether each such feature is present, and skips the relevant tests if not. Tests are generally verified by running the test both in MicroPython and in CPython and comparing the outputs. If the output differs the test fails and the outputs are saved in a .out and a .exp file respectively. For tests that cannot be run in CPython, for example because they use the machine module, a .exp file can be provided next to the test's .py file. A convenient way to generate that is to run the test, let it fail (because CPython cannot run it) and then copy the .out file (but not before checking it manually!) When creating new tests, anything that relies on float support should go in the float/ subdirectory. Anything that relies on import x, where x is not a built-in module, should go in the import/ subdirectory.