From ea145374e390e89c0d0ba28da447a2951081b91b Mon Sep 17 00:00:00 2001 From: stijn Date: Tue, 26 Mar 2024 16:11:11 +0100 Subject: [PATCH] windows: Make test skipping more granular. Signed-off-by: stijn --- .github/workflows/ports_windows.yml | 2 ++ tests/run-tests.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ports_windows.yml b/.github/workflows/ports_windows.yml index 7647749f77..91a3192a10 100644 --- a/.github/workflows/ports_windows.yml +++ b/.github/workflows/ports_windows.yml @@ -42,6 +42,8 @@ jobs: configuration: Debug - visualstudio: '2019' configuration: Debug + env: + CI_BUILD_CONFIGURATION: ${{ matrix.configuration }} runs-on: ${{ matrix.runner }} steps: - name: Install Visual Studio 2017 diff --git a/tests/run-tests.py b/tests/run-tests.py index 59ed179621..079b9a3259 100755 --- a/tests/run-tests.py +++ b/tests/run-tests.py @@ -580,7 +580,7 @@ def run_tests(pyb, tests, args, result_dir, num_threads=1): if os.getenv("GITHUB_ACTIONS") == "true": skip_tests.add("thread/stress_schedule.py") # has reliability issues - if os.getenv("RUNNER_OS") == "Windows": + if os.getenv("RUNNER_OS") == "Windows" and os.getenv("CI_BUILD_CONFIGURATION") == "Debug": # fails with stack overflow on Debug builds skip_tests.add("misc/sys_settrace_features.py")