From 271a73d7435e01554ea9086aba26fe63263954cd Mon Sep 17 00:00:00 2001
From: Christian Bayer <chrbayer84@googlemail.com>
Date: Tue, 31 Jan 2023 22:16:47 -0500
Subject: [PATCH] review changes

---
 package.nw/gt_roster.html                       |  6 ------
 package.nw/i18n/cn-t.json                       |  2 --
 package.nw/i18n/cn.json                         |  2 --
 package.nw/i18n/en.json                         |  2 --
 package.nw/lib/roster.js                        |  5 -----
 package.nw/lib/roster/processRosterFiltering.js | 16 ----------------
 6 files changed, 33 deletions(-)

diff --git a/package.nw/gt_roster.html b/package.nw/gt_roster.html
index e7a8e83..f5db234 100644
--- a/package.nw/gt_roster.html
+++ b/package.nw/gt_roster.html
@@ -356,12 +356,6 @@
                 <label data-i18n="roster.secondary.exceptions.noUnknownDXCC" >No Unknown DXCC</label>
               </div>
 
-              <div id="noUnknownRosterAlertsDiv">
-                <input type="checkbox" id="noUnknownRosterAlerts" onchange="valuesChanged();" />
-                <label data-i18n="roster.secondary.exceptions.noUnknownRosterAlerts" >No alerts for Calls</label>
-                <br/>
-                <label data-i18n="roster.secondary.exceptions.noUnknownRosterAlerts2" >w/ unknown CQ/State</label>
-              </div>
               <div>
                 <label title="No Decodes Containing...">
                   <input type="checkbox" id="noMsg" onchange="valuesChanged();" />
diff --git a/package.nw/i18n/cn-t.json b/package.nw/i18n/cn-t.json
index afd4b01..3bc2a9f 100644
--- a/package.nw/i18n/cn-t.json
+++ b/package.nw/i18n/cn-t.json
@@ -561,8 +561,6 @@
     "roster.secondary.exceptions.usesOQRS": "OQRS用戶",
     "roster.secondary.exceptions.wantRRCQ": "RR73 as CQ",
     "roster.secondary.exceptions.noUnknownDXCC": "No Unknown DXCC",
-    "roster.secondary.exceptions.noUnknownRosterAlerts": "No alerts for Calls",
-    "roster.secondary.exceptions.noUnknownRosterAlerts2": "w/ unknown CQ/State",
     "roster.secondary.exceptions.allOnlyNew": "僅限新呼號",
     "roster.secondary.exceptions.noMsg.label": "不包含",
     "roster.secondary.exceptions.noMsg.hover": "不包含解碼...",
diff --git a/package.nw/i18n/cn.json b/package.nw/i18n/cn.json
index a649655..83f7e6a 100644
--- a/package.nw/i18n/cn.json
+++ b/package.nw/i18n/cn.json
@@ -561,8 +561,6 @@
     "roster.secondary.exceptions.allOnlyNew": "仅限新呼号",
     "roster.secondary.exceptions.wantRRCQ": "RR73 as CQ",
     "roster.secondary.exceptions.noUnknownDXCC": "No Unknown DXCC",
-    "roster.secondary.exceptions.noUnknownRosterAlerts": "No alerts for Calls",
-    "roster.secondary.exceptions.noUnknownRosterAlerts2": "w/ unknown CQ/State",
     "roster.secondary.exceptions.noMsg.label": "不包含",
     "roster.secondary.exceptions.noMsg.hover": "不包含解码...",
     "roster.secondary.exceptions.onlyMsg.label": "只包含",
diff --git a/package.nw/i18n/en.json b/package.nw/i18n/en.json
index 896a5aa..bdd25a0 100644
--- a/package.nw/i18n/en.json
+++ b/package.nw/i18n/en.json
@@ -560,8 +560,6 @@
     "roster.secondary.exceptions.usesOQRS": "Uses OQRS",
     "roster.secondary.exceptions.wantRRCQ": "RR73 as CQ",
     "roster.secondary.exceptions.noUnknownDXCC": "No Unknown DXCC",
-    "roster.secondary.exceptions.noUnknownRosterAlerts": "No alerts for Calls",
-    "roster.secondary.exceptions.noUnknownRosterAlerts2": "w/ unknown CQ/State",
     "roster.secondary.exceptions.allOnlyNew": "Only New Calls",
     "roster.secondary.exceptions.noMsg.label": "No",
     "roster.secondary.exceptions.noMsg.hover": "No Decodes Containing...",
diff --git a/package.nw/lib/roster.js b/package.nw/lib/roster.js
index dfb8b3b..8648ec7 100644
--- a/package.nw/lib/roster.js
+++ b/package.nw/lib/roster.js
@@ -93,7 +93,6 @@ var g_defaultSettings = {
   allOnlyNew: false,
   useRegex: false,
   noUnknownDXCC: true,
-  noUnknownRosterAlerts: false,
   callsignRegex: "",
   huntRegexValue: "",
   realtime: true,
@@ -931,7 +930,6 @@ function setVisual()
     HuntModeControls.style.display = "none";
     CallsignsControls.style.display = "none";
     AwardTrackerControls.style.display = "";
-    noUnknownRosterAlertsDiv.style.display = "";
     updateAwardList();
   }
   else
@@ -945,7 +943,6 @@ function setVisual()
     }
 
     AwardTrackerControls.style.display = "none";
-    noUnknownRosterAlertsDiv.style.display = "none";
     HuntModeControls.style.display = "";
     huntMode.style.display = "";
     CallsignsControls.style.display = "";
@@ -1189,7 +1186,6 @@ function valuesChanged()
   g_rosterSettings.callsignRegex = callsignRegex.value;
   g_rosterSettings.huntRegexValue = huntRegexValue.value;
   g_rosterSettings.noUnknownDXCC = noUnknownDXCC.checked;
-  g_rosterSettings.noUnknownRosterAlerts = noUnknownRosterAlerts.checked;
 
   writeRosterSettings();
 
@@ -2327,7 +2323,6 @@ function addControls()
   huntRegexValue.value = g_rosterSettings.huntRegexValue;
 
   noUnknownDXCC.checked = g_rosterSettings.noUnknownDXCC;
-  noUnknownRosterAlerts.checked = g_rosterSettings.noUnknownRosterAlerts;
 
   clearRosterOnBandChange.checked = g_rosterSettings.clearRosterOnBandChange;
   rosterAlwaysOnTop.checked = g_rosterSettings.rosterAlwaysOnTop;
diff --git a/package.nw/lib/roster/processRosterFiltering.js b/package.nw/lib/roster/processRosterFiltering.js
index d683292..d860fd3 100644
--- a/package.nw/lib/roster/processRosterFiltering.js
+++ b/package.nw/lib/roster/processRosterFiltering.js
@@ -392,22 +392,6 @@ function processRosterFiltering(callRoster, rosterSettings)
           }
         }
       }
-      // if (g_rosterSettings.noUnknownRosterAlerts)
-      // {
-      //   if (callObj.dxcc === 291 || callObj.dxcc === 110 || callObj.dxcc === 6)
-      //   {
-      //     if (!callObj.state)
-      //     {
-      //       callObj.shouldAlert = false;
-      //       tx = false;
-      //     }
-      //   }
-      //   if (callObj.cqz === -1)
-      //   {
-      //     callObj.shouldAlert = false;
-      //     tx = false;
-      //   }
-      // }
       let didWork = (baseHash in g_worked.call);
       if (allOnlyNew.checked && didWork && !callObj.qrz)
       {