From 4cb2f53db3036a9fc55ccb61764c01094bb608b2 Mon Sep 17 00:00:00 2001 From: Eliot Berriot Date: Mon, 26 Jun 2017 18:10:38 +0200 Subject: [PATCH] Fixed #11: Upgraded to django 1.11 --- .env.dev | 2 +- api/config/api_urls.py | 6 ++++-- api/funkwhale_api/music/views.py | 3 ++- api/requirements/base.txt | 2 +- api/requirements/local.txt | 4 ++-- api/requirements/test.txt | 11 +++-------- dev.yml | 7 ++++--- 7 files changed, 17 insertions(+), 18 deletions(-) diff --git a/.env.dev b/.env.dev index 75954b6bc..de58e2758 100644 --- a/.env.dev +++ b/.env.dev @@ -1,3 +1,3 @@ -BACKEND_URL=http://localhost:6001 +BACKEND_URL=http://localhost:12081 YOUTUBE_API_KEY= API_AUTHENTICATION_REQUIRED=False diff --git a/api/config/api_urls.py b/api/config/api_urls.py index 4ed81d284..1da377116 100644 --- a/api/config/api_urls.py +++ b/api/config/api_urls.py @@ -2,6 +2,8 @@ from rest_framework import routers from django.conf.urls import include, url from funkwhale_api.music import views from funkwhale_api.playlists import views as playlists_views +from rest_framework_jwt import views as jwt_views + router = routers.SimpleRouter() router.register(r'tags', views.TagViewSet, 'tags') @@ -21,6 +23,6 @@ urlpatterns += [ url(r'^radios/', include('funkwhale_api.radios.urls', namespace='radios')), url(r'^history/', include('funkwhale_api.history.urls', namespace='history')), url(r'^users/', include('funkwhale_api.users.api_urls', namespace='users')), - url(r'^token/', 'rest_framework_jwt.views.obtain_jwt_token'), - url(r'^token/refresh/', 'rest_framework_jwt.views.refresh_jwt_token'), + url(r'^token/', jwt_views.obtain_jwt_token), + url(r'^token/refresh/', jwt_views.refresh_jwt_token), ] diff --git a/api/funkwhale_api/music/views.py b/api/funkwhale_api/music/views.py index 4887ad139..772f4173e 100644 --- a/api/funkwhale_api/music/views.py +++ b/api/funkwhale_api/music/views.py @@ -121,13 +121,14 @@ class TrackViewSet(TagViewSetMixin, SearchMixin, viewsets.ReadOnlyModelViewSet): class TagViewSet(viewsets.ReadOnlyModelViewSet): - queryset = Tag.objects.all() + queryset = Tag.objects.all().order_by('name') serializer_class = serializers.TagSerializer permission_classes = [ConditionalAuthentication] class Search(views.APIView): max_results = 3 + def get(self, request, *args, **kwargs): query = request.GET['query'] results = { diff --git a/api/requirements/base.txt b/api/requirements/base.txt index 626525572..0b9e03090 100644 --- a/api/requirements/base.txt +++ b/api/requirements/base.txt @@ -1,5 +1,5 @@ # Bleeding edge Django -django==1.8.7 +django==1.11 # Configuration django-environ==0.4.0 diff --git a/api/requirements/local.txt b/api/requirements/local.txt index ff8f35c74..3f681b26d 100644 --- a/api/requirements/local.txt +++ b/api/requirements/local.txt @@ -2,11 +2,11 @@ -r base.txt coverage==4.0.3 django_coverage_plugin==1.1 -Sphinx +Sphinx==1.6.2 django-extensions==1.5.9 Werkzeug==0.11.2 django-test-plus==1.0.11 -factory_boy==2.6.0 +factory_boy>=2.8.1 # django-debug-toolbar that works with Django 1.5+ django-debug-toolbar>=1.5,<1.6 diff --git a/api/requirements/test.txt b/api/requirements/test.txt index bcb6ef060..93509c573 100644 --- a/api/requirements/test.txt +++ b/api/requirements/test.txt @@ -1,12 +1,7 @@ # Test dependencies go here. --r base.txt +-r local.txt - -coverage==4.0.3 -django_coverage_plugin==1.1 flake8==2.5.0 -django-test-plus==1.0.11 -factory_boy>=2.8.1 -model_mommy -tox +model-mommy==1.3.2 +tox==2.7.0 diff --git a/dev.yml b/dev.yml index 526ce1ba8..21b0912e3 100644 --- a/dev.yml +++ b/dev.yml @@ -36,17 +36,18 @@ services: - C_FORCE_ROOT=true volumes: - ./api:/app - + - ./data/music:/music api: env_file: .env.dev build: context: ./api - dockerfile: docker/Dockerfile.local + dockerfile: docker/Dockerfile.test command: python /app/manage.py runserver 0.0.0.0:12081 volumes: - ./api:/app + - ./data/music:/music ports: - - "12081" + - "12081:12081" links: - postgres - redis