From e9dc9a11587c0b298935416b62cc8e544fbcf8fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mime=20=C4=8Cuvalo?= Date: Wed, 21 Feb 2024 15:19:56 +0000 Subject: [PATCH] menu fixes: add company links in general; add tracking to lang menu (#2902) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - the company links appear back in the burger menu. they could be selectively shown if mobile but i'd argue they should just always be there. - add the `track` to LanguageMenu to make the menu update. however, i'm a little annoyed that i don't understand why the Help menu already works without this :-/ ### Change Type - [x] `patch` — Bug fix ### Release Notes - Add company menu links back in and make sure the Language menu is updated on change. --- apps/dotcom/src/components/LocalEditor.tsx | 1 + apps/dotcom/src/components/MultiplayerEditor.tsx | 1 + packages/tldraw/src/lib/ui/components/LanguageMenu.tsx | 6 +++--- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/dotcom/src/components/LocalEditor.tsx b/apps/dotcom/src/components/LocalEditor.tsx index 255baf306..d9fc65408 100644 --- a/apps/dotcom/src/components/LocalEditor.tsx +++ b/apps/dotcom/src/components/LocalEditor.tsx @@ -45,6 +45,7 @@ const components: TLComponents = { + ), KeyboardShortcutsDialog: (props) => { diff --git a/apps/dotcom/src/components/MultiplayerEditor.tsx b/apps/dotcom/src/components/MultiplayerEditor.tsx index 5235c9bad..5331370f4 100644 --- a/apps/dotcom/src/components/MultiplayerEditor.tsx +++ b/apps/dotcom/src/components/MultiplayerEditor.tsx @@ -67,6 +67,7 @@ const components: TLComponents = { + ), KeyboardShortcutsDialog: (props) => { diff --git a/packages/tldraw/src/lib/ui/components/LanguageMenu.tsx b/packages/tldraw/src/lib/ui/components/LanguageMenu.tsx index f4a8c8db5..7f23a796d 100644 --- a/packages/tldraw/src/lib/ui/components/LanguageMenu.tsx +++ b/packages/tldraw/src/lib/ui/components/LanguageMenu.tsx @@ -1,11 +1,11 @@ -import { useEditor } from '@tldraw/editor' +import { track, useEditor } from '@tldraw/editor' import { useUiEvents } from '../context/events' import { useLanguages } from '../hooks/useTranslation/useLanguages' import { TldrawUiMenuCheckboxItem } from './primitives/menus/TldrawUiMenuCheckboxItem' import { TldrawUiMenuGroup } from './primitives/menus/TldrawUiMenuGroup' import { TldrawUiMenuSubmenu } from './primitives/menus/TldrawUiMenuSubmenu' -export function LanguageMenu() { +export const LanguageMenu = track(function LanguageMenu() { const editor = useEditor() const trackEvent = useUiEvents() const { languages, currentLanguage } = useLanguages() @@ -29,4 +29,4 @@ export function LanguageMenu() { ) -} +})