From 4245fd55b21d12bf5e065234aac13213435d7374 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mitja=20Bezen=C5=A1ek?= Date: Mon, 22 Apr 2024 17:33:25 +0200 Subject: [PATCH] Fix deploy script (#3550) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Seems like `tar` is moving to `ts` in version 7 and this caused some issues with imports. Saw this issue on [readonly PR](https://github.com/tldraw/tldraw/actions/runs/8783569356/job/24099998235?pr=3192#step:6:684), looks like a result of a [dependabot PR](https://github.com/tldraw/tldraw/pull/3505). ### Change Type - [ ] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [x] `internal` — Does not affect user-facing stuff - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [ ] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [x] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know --- scripts/deploy.ts | 2 +- scripts/package.json | 1 - yarn.lock | 13 +------------ 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/scripts/deploy.ts b/scripts/deploy.ts index ee15826cb..ff6353c5d 100644 --- a/scripts/deploy.ts +++ b/scripts/deploy.ts @@ -6,7 +6,7 @@ import { execSync } from 'child_process' import { appendFileSync, existsSync, readdirSync, writeFileSync } from 'fs' import path, { join } from 'path' import { PassThrough } from 'stream' -import tar from 'tar' +import * as tar from 'tar' import { exec } from './lib/exec' import { makeEnv } from './lib/makeEnv' import { nicelog } from './lib/nicelog' diff --git a/scripts/package.json b/scripts/package.json index 091173913..b49be8566 100644 --- a/scripts/package.json +++ b/scripts/package.json @@ -32,7 +32,6 @@ "@aws-sdk/lib-storage": "^3.440.0", "@types/is-ci": "^3.0.0", "@types/node": "~20.11", - "@types/tar": "^6.1.11", "@typescript-eslint/utils": "^5.59.0", "ast-types": "^0.14.2", "cross-fetch": "^3.1.5", diff --git a/yarn.lock b/yarn.lock index ef4b8a595..02650f560 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7579,7 +7579,6 @@ __metadata: "@types/is-ci": "npm:^3.0.0" "@types/minimist": "npm:^1.2.5" "@types/node": "npm:~20.11" - "@types/tar": "npm:^6.1.11" "@types/tmp": "npm:^0.2.6" "@typescript-eslint/utils": "npm:^5.59.0" ast-types: "npm:^0.14.2" @@ -8443,16 +8442,6 @@ __metadata: languageName: node linkType: hard -"@types/tar@npm:^6.1.11": - version: 6.1.11 - resolution: "@types/tar@npm:6.1.11" - dependencies: - "@types/node": "npm:*" - minipass: "npm:^4.0.0" - checksum: 0d54b8acbd7d2fc43bd1097eef5058604a6b0e3a394cf485038303ca3ef39ecb42451c7dc5a2b9b18420e137ef5b2c76ec504e94c2f45010b2c8e8c3a49d9de7 - languageName: node - linkType: hard - "@types/testing-library__jest-dom@npm:^5.9.1": version: 5.14.9 resolution: "@types/testing-library__jest-dom@npm:5.14.9" @@ -19133,7 +19122,7 @@ __metadata: languageName: node linkType: hard -"minipass@npm:^4.0.0, minipass@npm:^4.2.4": +"minipass@npm:^4.2.4": version: 4.2.8 resolution: "minipass@npm:4.2.8" checksum: e148eb6dcb85c980234cad889139ef8ddf9d5bdac534f4f0268446c8792dd4c74f4502479be48de3c1cce2f6450f6da4d0d4a86405a8a12be04c1c36b339569a