From 76a061b86af6688e7b742f72e2cea4a1f490355e Mon Sep 17 00:00:00 2001 From: Piero Toffanin Date: Mon, 11 Dec 2023 14:57:21 -0500 Subject: [PATCH] Deprecate texturing-skip-local-seam-leveling --- opendm/config.py | 9 +-------- stages/mvstex.py | 5 ----- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/opendm/config.py b/opendm/config.py index 849b59ce..3f51ff20 100755 --- a/opendm/config.py +++ b/opendm/config.py @@ -97,7 +97,6 @@ rerun_stages = { 'texturing_keep_unseen_faces': 'mvs_texturing', 'texturing_single_material': 'mvs_texturing', 'texturing_skip_global_seam_leveling': 'mvs_texturing', - 'texturing_skip_local_seam_leveling': 'mvs_texturing', 'tiles': 'odm_dem', 'use_3dmesh': 'mvs_texturing', 'use_exif': 'dataset', @@ -543,12 +542,6 @@ def config(argv=None, parser=None): default=False, help=('Skip normalization of colors across all images. Useful when processing radiometric data. Default: %(default)s')) - parser.add_argument('--texturing-skip-local-seam-leveling', - action=StoreTrue, - nargs=0, - default=False, - help='Skip the blending of colors near seams. Default: %(default)s') - parser.add_argument('--texturing-keep-unseen-faces', action=StoreTrue, nargs=0, @@ -887,7 +880,7 @@ def config(argv=None, parser=None): 'Default: %(default)s')) args, unknown = parser.parse_known_args(argv) - DEPRECATED = ["--verbose", "--debug", "--time", "--resize-to", "--depthmap-resolution", "--pc-geometric", "--texturing-data-term", "--texturing-outlier-removal-type", "--texturing-tone-mapping"] + DEPRECATED = ["--verbose", "--debug", "--time", "--resize-to", "--depthmap-resolution", "--pc-geometric", "--texturing-data-term", "--texturing-outlier-removal-type", "--texturing-tone-mapping", "--texturing-skip-local-seam-leveling"] unknown_e = [p for p in unknown if p not in DEPRECATED] if len(unknown_e) > 0: raise parser.error("unrecognized arguments: %s" % " ".join(unknown_e)) diff --git a/stages/mvstex.py b/stages/mvstex.py index 6170533a..a45c3b17 100644 --- a/stages/mvstex.py +++ b/stages/mvstex.py @@ -81,14 +81,11 @@ class ODMMvsTexStage(types.ODM_Stage): # Format arguments to fit Mvs-Texturing app skipGlobalSeamLeveling = "" - skipLocalSeamLeveling = "" keepUnseenFaces = "" nadir = "" if args.texturing_skip_global_seam_leveling: skipGlobalSeamLeveling = "--skip_global_seam_leveling" - if args.texturing_skip_local_seam_leveling: - skipLocalSeamLeveling = "--skip_local_seam_leveling" if args.texturing_keep_unseen_faces: keepUnseenFaces = "--keep_unseen_faces" if (r['nadir']): @@ -102,7 +99,6 @@ class ODMMvsTexStage(types.ODM_Stage): 'dataTerm': 'gmi', 'outlierRemovalType': 'gauss_clamping', 'skipGlobalSeamLeveling': skipGlobalSeamLeveling, - 'skipLocalSeamLeveling': skipLocalSeamLeveling, 'keepUnseenFaces': keepUnseenFaces, 'toneMapping': 'none', 'nadirMode': nadir, @@ -125,7 +121,6 @@ class ODMMvsTexStage(types.ODM_Stage): '-t {toneMapping} ' '{intermediate} ' '{skipGlobalSeamLeveling} ' - '{skipLocalSeamLeveling} ' '{keepUnseenFaces} ' '{nadirMode} ' '{labelingFile} '