e796f49d8e
See #23220 : Use jakarta.annotation instead of javax.annotation (JSR305)
...
Some lint issues were also fixed.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-10-25 10:49:59 -06:00
dd3cb880a6
Decrease allocations from listing the layers
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-08 13:52:36 -06:00
056b9db064
Reduce startup costs
...
This largely focuses on reducing memory allocations.
There are also some conversions to Java 17 standards.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-02 09:59:22 -06:00
e5b228bdba
Fix #22728 : No URL for provider
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-14 08:27:57 -07:00
9a61f34d7f
Fix many SonarLint issues, mostly documentation
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-06 14:32:30 -07:00
89c7d898ce
MapWithAILayerInfo: Fix an IllegalMonitorStateException
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-08-30 06:57:49 -06:00
840cadb61b
Lint fixes
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-22 12:26:24 -06:00
1dc1f18e8e
ESRI: Get data in a ForkJoinPool (significant speedup)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:02:29 -06:00
1ff3296863
MapWithAILayerInfo: Fix EDT violation
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 15:07:20 -06:00
0d24b66fd7
Fix issue with UI blocking
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-13 08:53:20 -06:00
42aec40b25
MapWithAIInfo: Fix an issue where users would be unable to file bug reports
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-12 12:21:55 -06:00
cf01febcf1
Fix URL reset on JOSM restart
...
This was reported on Slack by drkludge.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-06 16:50:15 -07:00
ca85a58cae
Fix issue where downloaded bounds is expanded
...
Also fix some lint issues, and remove last non-guarded reference to
ForkJoinPool.commonPool.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 13:44:09 -07:00
0f8072833a
Fix JOSM #21623 : ACE in MapWithAILayerInfo
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 09:57:52 -07:00
9f424eaaa2
DataConflationSender: Add initial tests
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-11-11 08:20:29 -07:00
99f4de5dd4
Rework URL handling
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-11-10 11:24:10 -07:00
5930bda453
MapWithAILayerInfo: Fix typo
...
Call was to NetworkManager#isOffline, but was stored in a variable named
"online". Fix: Invert the returned boolean from NetworkManager#isOffline
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-10-19 07:16:45 -06:00
453ceb38b9
MapWithAILayerInfo: Fix CME
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-10-18 14:30:57 -06:00
ef13fd97d4
EsriSourceReader: Lazily load replacement tags
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-10-18 12:02:00 -06:00
849f571837
Lint: Cleanup warnings on build
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 14:54:21 -06:00
5cb5262128
MapWithAI SourceReaders: Create common class for deduplication
...
Also ensure that users can ignore cache for MapWithAI sources.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 14:54:21 -06:00
a23e94be0d
Tests: Better test isolation
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-08 06:06:14 -06:00
a0ed7272aa
Gradle: Dependency updates + fix for errorprone
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-07 08:30:42 -06:00
f9308da42f
MapWithAILayerInfo: Sort all entries
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-20 14:12:49 -06:00
7bfffa3a10
MapWithAILayerInfo: Reduce initial allocations
...
For this, we just avoid saving preferences until we are are't getting
all the data sources.
For most users, this should have no effect. Only users that open JOSM,
quickly make a preference change, and exit without the preference.save
method being called will have issues.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-01 08:22:27 -06:00
ed6b8bcd5d
MapWithAILayerInfo: Don't block JOSM startup
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-01 08:22:27 -06:00
10e3ad76a7
FIXUP: Don't show preview data sets when expert mode is not checked
...
This fixes #99 .
This also changes the default classpath for the JRE, so that it
hopefully just works on different machines.
The minimum JOSM version is also bumped to the current stable.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 07:27:58 -06:00
4ed09dd7e1
FIXUP: Spotbugs
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 11:39:46 -06:00
5d81c2906f
Fix some compile warnings
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 08:53:02 -06:00
267c97200f
FIXUP: Avoid a potential deadlock on the EDT
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-29 16:27:45 -06:00
45d424e885
Dynamically produce source tags for Esri sources
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-26 09:08:31 -06:00
97dc67abc1
Don't show preview sources, unless expert preference has been modified
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-26 07:58:34 -06:00
a90f7f626c
FIXUP: Currently, there should be _no_ remote control based conflation servers. Remove them from entries.
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-25 14:35:45 -06:00
5b4d06b96a
Ensure that MapWithAILayerInfo is always called when test rules set it up
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-24 15:00:33 -06:00
69d69e8df3
Add a wiremock response transformer
...
This ensures that any URL's in the response are also mocked (or fails
the test).
I also fixed a listener bug for MapWithAILayerInfo.
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-24 14:00:56 -06:00
ab34c3843e
Actually use wiremock for some tests (url's weren't always being reset)
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-24 14:00:56 -06:00
35768d1997
Make MapWithAILayerInfo.instance private
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-24 14:00:51 -06:00
5cf2aafd1a
Fix JOSM-19420
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-22 08:27:38 -06:00
a338a96f1d
Update MapWithAIInfo when preferences are null
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-18 16:22:22 -06:00
db7089e406
Enable/disable download based off of user interactions in the layer panel
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-18 14:52:40 -06:00
cde1e3f60a
Split some classes into their own files and fix some sonarlint issues.
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-10 16:31:44 -06:00
60b99acef9
Extract ESRI server reader to separate file
...
* Also add source provider information
* Update pjson -> json (the latter is slightly more efficient)
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 17:07:47 -06:00
21d5c6b477
Spotbugs, errorprone fixes
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:32:01 -06:00
e548bdd3c3
Use streams, add check to avoid NPE, and default to OTHER as a type.
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:32:01 -06:00
328f3b96b1
ESRI branch
2020-06-03 16:32:00 -06:00
50556cab86
Use "" instead of null (avoid NPE)
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:31:59 -06:00
e1acbc7ea3
Only keep editable fields, but assume that a field is editable if the property does not exist
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:31:55 -06:00
36223efe5d
Add fields for conflation information
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:31:50 -06:00
d7fe108f1f
Initial implementation for setting sources in download
...
* Add checkbox to main UI download panel
* For more information, see JOSM-18340
* There have been some modifications so that both JOSM UI panel download
methods use the same class to download.
* Reuse panel from preferences for setting sources
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:31:48 -06:00
5d883d8fd4
Create a special third-party case for ESRI servers
...
This currently supports groups (the id in the sources.json *must* be the
group id) and specific FeatureServers.
This should only be used when (a) permission is given for OpenStreetMap
to use the data and (b) the server owner has given their OK. While the
feature calls should be as efficient as possible, many server owners
will be paying for data transfer.
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-03 16:31:42 -06:00
Taylor Smock