GS-232B: Fix frequent hangs because of wrong end of line

From Paul:
" ...   I am using the Win32 hamlib program, rotctl.exe
version 1.2.15.1 with a Yaesu GS-232B antenna rotator controller interface
device.  Rotctl.exe is not operating as expected however.  It frequently
hangs on some of the commands.  I have successfully commanded the
controller using a dumb terminal and I have watched the characters that are
sent with a scope.  It appears that the hamlib rotctl.exe is sending
incorrect line termination characters when sending out commands.  It should
send carriage return only ("\r") and not carriage return and line feed
("\r\n") as it is currently doing.

I have attached page 15 from the user manual for the Yaesu GS-232B
controller interface device (also found at
http://gatorradio.org/Manuals/Yaesu_GS-232B_Manual.pdf) which shows the
proper line terminators."

Signed-off-by: Paul Lafferty <plaff65@gmail.com>
Signed-off-by: Stephane Fillod <fillods@users.sf.net>
Hamlib-3.0
Stephane Fillod 2012-06-09 19:04:49 +02:00
rodzic 600be45fb8
commit c78952310a
1 zmienionych plików z 5 dodań i 5 usunięć

Wyświetl plik

@ -1,6 +1,6 @@
/*
* Hamlib Rotator backend - GS-232B
* Copyright (c) 2001-2010 by Stephane Fillod
* Copyright (c) 2001-2012 by Stephane Fillod
* (c) 2010 by Kobus Botha
*
*
@ -37,8 +37,8 @@
#include "gs232a.h"
#define EOM "\r\n"
#define REPLY_EOM "\r"
#define EOM "\r"
#define REPLY_EOM "\r\n"
#define BUFSZ 64
@ -58,7 +58,7 @@
* RIG_REJECTED - if a negative acknowledge was received or command not
* recognized by rig.
*/
int
static int
gs232b_transaction (ROT *rot, const char *cmdstr,
char *data, size_t data_len)
{
@ -243,7 +243,7 @@ const struct rot_caps gs232b_rot_caps = {
.rot_model = ROT_MODEL_GS232B,
.model_name = "GS-232B",
.mfg_name = "Yaesu",
.version = "0.1",
.version = "0.2",
.copyright = "LGPL",
.status = RIG_STATUS_BETA,
.rot_type = ROT_TYPE_OTHER,