diff --git a/Segfault-award b/Segfault-award index db4d10af4..2d02ce1bc 100644 --- a/Segfault-award +++ b/Segfault-award @@ -29,3 +29,7 @@ Here is the list of the brave fellows: * John Nelson G4KLA 09/2021 kenwood_set_vfo https://github.com/Hamlib/Hamlib/issues/794 + +* Josef 'Jeff' Sipek + netrigctl power2mW overflow + https://github.com/Hamlib/Hamlib/issues/855 diff --git a/rigs/dummy/netrigctl.c b/rigs/dummy/netrigctl.c index de8271dbb..a2591ee62 100644 --- a/rigs/dummy/netrigctl.c +++ b/rigs/dummy/netrigctl.c @@ -2538,13 +2538,14 @@ static int netrigctl_mW2power(RIG *rig, float *power, unsigned int mwpower, static int netrigctl_power2mW(RIG *rig, unsigned int *mwpower, float power, freq_t freq, rmode_t mode) { - char cmdbuf[32]; + char cmdbuf[64]; char buf[BUF_MAX]; int ret; ENTERFUNC; - sprintf(cmdbuf, "\\power2mW %f %.0f %s\n", power, freq, rig_strrmode(mode)); + // we shouldn't need any precision than microwatts + snprintf(cmdbuf, sizeof(cmdbuf), "\\power2mW %.3f %.0f %s\n", power, freq, rig_strrmode(mode)); ret = netrigctl_transaction(rig, cmdbuf, strlen(cmdbuf), buf); if (ret <= 0) @@ -2568,7 +2569,7 @@ struct rig_caps netrigctl_caps = RIG_MODEL(RIG_MODEL_NETRIGCTL), .model_name = "NET rigctl", .mfg_name = "Hamlib", - .version = "20211030.0", + .version = "20211107.0", .copyright = "LGPL", .status = RIG_STATUS_STABLE, .rig_type = RIG_TYPE_OTHER,