kopia lustrzana https://github.com/Hamlib/Hamlib
Remove icom_set_rit - it doesn't (and can't) work - see README.icom
rodzic
29ae878fa7
commit
1138feb576
|
@ -41,3 +41,18 @@ icr8600 3 2
|
|||
icr9000 2 2
|
||||
icr9500 3 2
|
||||
|
||||
2020-09, G0GJV Attempting to support RIT. I asked ICOM technical support
|
||||
|
||||
"I am doing some work on the Hamlib amateur radio control library, and in
|
||||
particular looking at control of RIT via CI-V on the Icom IC-9100 Is my
|
||||
reading of the manual correct - on this (and most older Icom rigs) -
|
||||
there is no RIT/XIT control available?"
|
||||
|
||||
and received the answer
|
||||
|
||||
"Hi Mike,
|
||||
Yes that's right
|
||||
Thanks
|
||||
Virgil"
|
||||
|
||||
So I've removed the erroneous icom_set_rit function.
|
|
@ -360,8 +360,6 @@ const struct rig_caps ic7100_caps =
|
|||
.set_ptt = icom_set_ptt,
|
||||
.get_ptt = icom_get_ptt,
|
||||
|
||||
.set_rit = icom_set_rit,
|
||||
|
||||
.set_rptr_shift = icom_set_rptr_shift,
|
||||
.get_rptr_shift = icom_get_rptr_shift,
|
||||
.set_rptr_offs = icom_set_rptr_offs,
|
||||
|
|
|
@ -239,8 +239,6 @@ const struct rig_caps ic7410_caps =
|
|||
.set_ant = icom_set_ant,
|
||||
.get_ant = icom_get_ant,
|
||||
|
||||
.set_rit = icom_set_rit,
|
||||
|
||||
.decode_event = icom_decode_event,
|
||||
.set_level = ic7410_set_level,
|
||||
.get_level = ic7410_get_level,
|
||||
|
|
|
@ -252,8 +252,6 @@ const struct rig_caps ic9100_caps =
|
|||
.set_ptt = icom_set_ptt,
|
||||
.get_ptt = icom_get_ptt,
|
||||
|
||||
.set_rit = icom_set_rit,
|
||||
|
||||
.set_rptr_shift = icom_set_rptr_shift,
|
||||
.get_rptr_shift = icom_get_rptr_shift,
|
||||
.set_rptr_offs = icom_set_rptr_offs,
|
||||
|
|
|
@ -1256,37 +1256,6 @@ int icom_get_freq(RIG *rig, vfo_t vfo, freq_t *freq)
|
|||
return RIG_OK;
|
||||
}
|
||||
|
||||
int icom_set_rit(RIG *rig, vfo_t vfo, shortfreq_t rit)
|
||||
{
|
||||
unsigned char freqbuf[MAXFRAMELEN], ackbuf[MAXFRAMELEN];
|
||||
int freq_len, ack_len = sizeof(ackbuf), retval;
|
||||
|
||||
|
||||
rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
|
||||
freq_len = 2;
|
||||
/*
|
||||
* to_bcd requires nibble len
|
||||
*/
|
||||
to_bcd(freqbuf, rit, freq_len * 2);
|
||||
|
||||
retval = icom_transaction(rig, C_SET_OFFS, -1, freqbuf, freq_len,
|
||||
ackbuf, &ack_len);
|
||||
|
||||
if (retval != RIG_OK)
|
||||
{
|
||||
return retval;
|
||||
}
|
||||
|
||||
if (ack_len != 1 || ackbuf[0] != ACK)
|
||||
{
|
||||
rig_debug(RIG_DEBUG_ERR, "%s: ack NG (%#.2x), len=%d\n", __func__,
|
||||
ackbuf[0], ack_len);
|
||||
return -RIG_ERJCTED;
|
||||
}
|
||||
|
||||
return RIG_OK;
|
||||
}
|
||||
|
||||
int icom_get_rit_new(RIG *rig, vfo_t vfo, shortfreq_t *ts)
|
||||
{
|
||||
unsigned char tsbuf[MAXFRAMELEN];
|
||||
|
|
|
@ -222,7 +222,6 @@ int icom_rig_close(RIG *rig);
|
|||
int icom_cleanup(RIG *rig);
|
||||
int icom_set_freq(RIG *rig, vfo_t vfo, freq_t freq);
|
||||
int icom_get_freq(RIG *rig, vfo_t vfo, freq_t *freq);
|
||||
int icom_set_rit(RIG *rig, vfo_t vfo, shortfreq_t rit);
|
||||
int icom_get_rit_new(RIG *rig, vfo_t vfo, shortfreq_t *ts);
|
||||
int icom_set_rit_new(RIG *rig, vfo_t vfo, shortfreq_t ts);
|
||||
int icom_set_xit_new(RIG *rig, vfo_t vfo, shortfreq_t ts);
|
||||
|
|
|
@ -271,8 +271,6 @@ const struct rig_caps x108g_caps =
|
|||
.set_ant = NULL, /*automatically set by rig depending band */
|
||||
.get_ant = NULL,
|
||||
|
||||
.set_rit = icom_set_rit,
|
||||
|
||||
.decode_event = icom_decode_event,
|
||||
.set_level = icom_set_level,
|
||||
.get_level = icom_get_level,
|
||||
|
|
Ładowanie…
Reference in New Issue